Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1aa7364ed9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| anyhow = "1.0" | ||
| arc-swap = { version = "1.8" } | ||
| arrow-array = { version = "57.0", default-features = false } | ||
| arrow-array = { version = "58.1", default-features = false } |
There was a problem hiding this comment.
Align Arrow workspace deps to one major version
Bumping only arrow-array to 58.1 while leaving arrow-schema/arrow-buffer at 57.x introduces two incompatible Arrow type universes in the workspace (as reflected in Cargo.lock, where lading and lading-capture now depend on arrow-array 58.1.0 plus arrow-schema 57.3.0/arrow-buffer 57.3.0). Crates like lading_capture/src/formats/parquet.rs mix these APIs directly (MapArray/RecordBatch with Field/Schema/OffsetBuffer), which will fail with mismatched-type errors once the project is checked in a normal toolchain. Please upgrade the related Arrow crates together (or keep arrow-array on 57.x).
Useful? React with 👍 / 👎.
1aa7364 to
5fdd575
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5fdd57511c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| anyhow = "1.0" | ||
| arc-swap = { version = "1.8" } | ||
| arrow-array = { version = "57.0", default-features = false } | ||
| arrow-array = { version = "58.1", default-features = false } |
There was a problem hiding this comment.
Align parquet and arrow-array majors before runtime downcasts
Bumping only arrow-array to 58.1 while parquet/arrow-schema remain on 57.x creates two incompatible Arrow concrete types in the same binary. Fresh evidence beyond the existing compile-time concern: ParquetRecordBatchReaderBuilder (from parquet 57) yields 57.x arrays, but captool analysis and parquet validation downcast to 58.x StringArray/MapArray (lading/src/bin/captool/analyze/parquet.rs, lading_capture/src/validate/parquet.rs), so downcast_ref will always fail and valid parquet files are misreported as InvalidColumnType.
Useful? React with 👍 / 👎.
Bumps [arrow-array](https://github.com/apache/arrow-rs) from 57.1.0 to 58.1.0. - [Release notes](https://github.com/apache/arrow-rs/releases) - [Changelog](https://github.com/apache/arrow-rs/blob/main/CHANGELOG.md) - [Commits](apache/arrow-rs@57.1.0...58.1.0) --- updated-dependencies: - dependency-name: arrow-array dependency-version: 58.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
5fdd575 to
775bc9a
Compare
|
Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting |
Bumps arrow-array from 57.3.0 to 58.1.0.
Release notes
Sourced from arrow-array's releases.
... (truncated)
Changelog
Sourced from arrow-array's changelog.
... (truncated)
Commits
6cadf3bPrepare for 58.1.0 Release (#9573)322f9ce[Variant] Add unshred_variant support for Binary and LargeBinary types (#9576)bc74c71feat(parquet): add content defined chunking for arrow writer (#9450)39dda22Make Sbbf Constructers Public (#9569)d53df60feat: Optimize from_bitwise_binary_op with 64-bit alignment (#9441)44f5dfcperf: Coalesce page fetches when RowSelection selects all rows (#9578)14f1eb9pyarrow: Cache the imported classes to avoid importing them each time (#9439)55a7768[Variant] Addvariant_to_arrowStructtype support (#9572)42ab0bcfix: Usedchecked_addfor bounds checks to avoid UB (#9568)88422cbarrow-flight: generate dict_ids for dicts nested inside complex types (#9556)